✨ feat: added pydantic model for manifest validation #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
requested review from
ankitrgadiya,
sharmayajush and
amitsingh21
and removed request for
a team and
sharmayajush
guptadev21
force-pushed
the
feat/manifest-validation
branch
7 times, most recently
from
45143e6 to
c186df2
Compare
ankitrgadiya
reviewed
Sep 8, 2025
guptadev21
force-pushed
the
feat/manifest-validation
branch
2 times, most recently
from
f5794b6 to
0f1d84e
Compare
…work, Organization, Package, Project, Secret, StaticRoute, and User
…e response validation - Updated network tests to utilize Network and NetworkList models, enhancing response validation. - Refactored organization tests to use Organization model for better structure and clarity. - Modified package tests to implement Package and PackageList models, ensuring accurate response checks. - Revised project tests to leverage Project and ProjectList models for improved data handling. - Enhanced secret tests to utilize Secret and SecretList models, streamlining response validation. - Updated static route tests to incorporate StaticRoute and StaticRouteList models for better consistency. - Refactored user tests to use appropriate Pydantic models, improving clarity and response validation.
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
0f1d84e to
889383f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive Pydantic model validation for SDK resources to replace the old JSONSchema validation, improving error messaging and maintainability.
Key Changes
- Replaced Munch objects with strongly typed Pydantic models for all API responses
- Migrated from JSONSchema to Pydantic validation for manifest/resource validation
- Updated test suite to use proper mock data fixtures and structured assertion patterns
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
rapyuta_io_sdk_v2/client.py |
Added Pydantic model validation for all API methods and updated return types |
rapyuta_io_sdk_v2/utils.py |
Removed handle_and_munchify_response decorator and munch dependencies |
rapyuta_io_sdk_v2/pydantic_models/ |
New comprehensive Pydantic models for all resource types |
tests/sync_tests/ |
Updated test files to use Pydantic model fixtures and structured assertions |
tests/async_tests/ |
Updated async test files with similar validation and fixture improvements |
tests/data/mock_data.py |
Significantly expanded mock data with proper Pydantic model fixtures |
Comments suppressed due to low confidence (1)
tests/sync_tests/test_managedservice.py:1
- Duplicate function definitions detected. The
test_create_instance_binding_successfunction appears twice with identical logic (lines 167-188 and 217-225), which suggests a copy-paste error during refactoring.
import httpx
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ethods for validation
…mproved readability and maintainability
…methods to use model instances directly
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
1f9e28d to
9af30e9
Compare
…cClient and Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What’s new in this PR
💡 Why this matters
resolves https://github.com/rapyuta-robotics/rapyuta_io/issues/922